chrore: add linting action #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindhe
approved these changes
Feb 28, 2025
.github/workflows/lint-test.yml
Outdated
|
|
||
| jobs: | ||
| lint-test: | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Pretty old Ubuntu? OK by me if this works, but if a newer version works then we can rely on that longer into the future…
There was a problem hiding this comment.
I used the same one we have for the release action: https://github.com/inveniosoftware/helm-invenio/blob/master/.github/workflows/release.yml#L12
I'll test a newer one.
There was a problem hiding this comment.
I upgraded it to 24.04, the latest version, and it works fine. I'll update the release action when I make a new release, that way I can test it 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses https://github.com/helm/chart-testing-action just for linting right now.
Let me know what you think. It already complained that we were missing
maintainersfrom theChart.yamlfile 😂