Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: building images and pushing to a registry #39

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Mar 23, 2020

This PR adds documentation on how to build the docker image for InvenioRDM and how to push it to several registries (GitHub, OpenShift and DockerHub).

Requires: inveniosoftware/cookiecutter-invenio-rdm#56

Question:
Since GitHub requires a password/token stored in OpenShift. Options are:

a. We can leave it as is, and make the user build the image (2-3 mins) and push it to a registry.
b. Build the default image (that we have to do anyway) and push it to DockerHub so everybody has access to pull it.

Note: if we opt for a we can just push our image to CERN OpenShift or CERN GitLab registry.

WDYT? @lnielsen @zzacharo @fenekku

Decision will close inveniosoftware/demo-inveniordm#7

Copy link
Member

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general nice job! Some minor comments here and there :)

@ppanero
Copy link
Member Author

ppanero commented Mar 23, 2020

@zzacharo Thanks! fixed the typos and re-wrote the part of the image yaml. Please resolve the comment if you are okay with it :)

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are good instructions. What could we do to separate the Openshift specific instructions, from the other means specific instructions, from general instructions that are valid for all? I am tempted to have a separate Openshift folder with the many documentation files in it and other folders for other technologies...

@ppanero
Copy link
Member Author

ppanero commented Mar 23, 2020

@fenekku I understand that we have many "OpenShift" related documentation. But at the moment is the only "production" deployment that we have, and is the only technology we support (for now). I think at this point spreading documentation is a bit of an overkill, since we do not know 10% what are the changes that are gonna be needed afterwards.

Once we have support for something else (e.g. bare Kube) I agree with the refactoring, but having an idea of what is different to refactor.

Answered the two questions, thanks for the review!

@fenekku
Copy link
Collaborator

fenekku commented Mar 24, 2020

Sure... Our IT is probably not going to use Openshift, so that was a partly selfish ask 😸 . We'll see if it's easy enough to translate.

@fenekku fenekku self-requested a review March 24, 2020 13:18
@ppanero ppanero merged commit a3f60fc into inveniosoftware:master Mar 24, 2020
@ppanero ppanero deleted the images branch March 24, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push demo site image to registry
3 participants