Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: fix warning 'version' is obsolete #37

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Apr 13, 2024

❤️ Thank you for your contribution!

Description

While executing tests on other packages namely invenio-files-rest, I encountered a warning:
WARN[0000] site-packages/docker_services_cli/docker-services.yml: "version" is obsolete.
Upon further investigation, it appears that the version field is now redundant and can be safely removed to prevent this warning docker/compose#11628.

This PR addresses this issue by removing the obsolete version field from the docker-compose file.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ntarocco ntarocco merged commit 77fd708 into inveniosoftware:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants