-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase sleep time during logs tests #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 94.28% 94.21% -0.07%
==========================================
Files 5 5
Lines 175 173 -2
==========================================
- Hits 165 163 -2
Misses 10 10
Continue to review full report at Codecov.
|
There are a few other sleeps, maybe set a variable for the amount and use it within all of those? |
That is an option but I'm not sure how well that would work since there are sleep values that range from 1, 5, or 10 seconds. If I make them all use the same variable they'd all be 10 seconds which is probably sleeping more than we need for most cases. |
Yeah that's fair. Tbh these online tests, and testing in general needs to be re-worked as it's just awkward to get stuff to work together when you're creating/deleting resources really quickly. |
Ya this is definitely not a permanent solution but hopefully this will make the CI less noisy for the time being. |
These changes should hopefully fix this reoccurring CI test failure issue.