Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase sleep time during logs tests #39

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

TylerLoewen
Copy link
Contributor

These changes should hopefully fix this reoccurring CI test failure issue.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #39 (211978b) into master (1819fca) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   94.28%   94.21%   -0.07%     
==========================================
  Files           5        5              
  Lines         175      173       -2     
==========================================
- Hits          165      163       -2     
  Misses         10       10              
Impacted Files Coverage Δ
src/handler.jl 92.68% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1819fca...211978b. Read the comment docs.

@mattBrzezinski
Copy link
Member

There are a few other sleeps, maybe set a variable for the amount and use it within all of those?

@TylerLoewen
Copy link
Contributor Author

There are a few other sleeps, maybe set a variable for the amount and use it within all of those?

That is an option but I'm not sure how well that would work since there are sleep values that range from 1, 5, or 10 seconds. If I make them all use the same variable they'd all be 10 seconds which is probably sleeping more than we need for most cases.

@mattBrzezinski
Copy link
Member

There are a few other sleeps, maybe set a variable for the amount and use it within all of those?

That is an option but I'm not sure how well that would work since there are sleep values that range from 1, 5, or 10 seconds. If I make them all use the same variable they'd all be 10 seconds which is probably sleeping more than we need for most cases.

Yeah that's fair. Tbh these online tests, and testing in general needs to be re-worked as it's just awkward to get stuff to work together when you're creating/deleting resources really quickly.

@TylerLoewen
Copy link
Contributor Author

There are a few other sleeps, maybe set a variable for the amount and use it within all of those?

That is an option but I'm not sure how well that would work since there are sleep values that range from 1, 5, or 10 seconds. If I make them all use the same variable they'd all be 10 seconds which is probably sleeping more than we need for most cases.

Yeah that's fair. Tbh these online tests, and testing in general needs to be re-worked as it's just awkward to get stuff to work together when you're creating/deleting resources really quickly.

Ya this is definitely not a permanent solution but hopefully this will make the CI less noisy for the time being.

@TylerLoewen TylerLoewen merged commit 7f95ed1 into master Sep 15, 2021
@TylerLoewen TylerLoewen deleted the tl/fix-online-tests branch September 15, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

So many logs: Test Failed: length(response["events"]) == 1
3 participants