Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleeps before getting responses #32

Closed
wants to merge 1 commit into from
Closed

Add sleeps before getting responses #32

wants to merge 1 commit into from

Conversation

mjram0s
Copy link
Member

@mjram0s mjram0s commented Jun 22, 2021

We seem to get a lot of AWS timing issues in the online tests. Hopefully adding sleeps will mitigate this.

Related to #30

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #32 (c4e1d7e) into master (b47c2ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files           5        5           
  Lines         172      172           
=======================================
  Hits          162      162           
  Misses         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47c2ca...c4e1d7e. Read the comment docs.

@mjram0s mjram0s changed the title Add sleep times before getting responses Add sleeps before getting responses Jun 22, 2021
@mjram0s
Copy link
Member Author

mjram0s commented Jul 21, 2021

Adding/increasing sleeps is still resulting in the same issue. See https://github.com/invenia/CloudWatchLogs.jl/runs/2888235872#step:6:15. This doesn't seem to be the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant