Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AWSCore with AWS.jl #29

Closed
wants to merge 2 commits into from
Closed

Replace AWSCore with AWS.jl #29

wants to merge 2 commits into from

Conversation

ararslan
Copy link
Collaborator

See #28 for context/discussion. This is the same set of changes but from a branch on the repo rather than from a fork.

Fixes #27.

@ararslan
Copy link
Collaborator Author

Either permissions are still weird or I've messed something up.

@mattBrzezinski
Copy link
Member

👀 didn't realize this was even a thing... oops #34

@mattBrzezinski
Copy link
Member

@ararslan any capacity to finish this off? I can close my PR if anything. I'll update the permissions on the stack so this should run successfully.

I will note, we should probably bump versions for other deps while we're here.

@ararslan
Copy link
Collaborator Author

any capacity to finish this off?

Unfortunately not, happy to close if you'd prefer, or feel free to push directly to this branch if you're interested in picking it up from here

@mattBrzezinski
Copy link
Member

any capacity to finish this off?

Unfortunately not, happy to close if you'd prefer, or feel free to push directly to this branch if you're interested in picking it up from here

I'll close this in favour of #35 and cherry pick in any of these changes that I prefer!

@ararslan ararslan deleted the aa/aws-jl branch August 24, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not play nicely with AWS.jl
2 participants