reslove : #425 #428
Closed
reslove : #425 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bean3 Please explain your commit. It looks that it just unify and simplify current probability calculation code. |
Alpacadabra
requested changes
Apr 18, 2018
There was a problem hiding this comment.
- 저장소가 엉망이 된 후에 pull을 하신적이 있나요? indentation 에러가 발생합니다.
- gameFunction.py 의 line 473에서 random.randrange(1, 5)를 인수로 전달하셨는데 정수값으로는 item의 image에 대한 어떠한 조건도 만족시키지 못합니다. item.py를 참고하세요.
- 기존 코드들을 주석으로 굳이 남겨두실 필요는 없습니다.
- 띄어쓰기를 일관되게 사용해주세요.
pull request를 올리기 전에 꼭 실행 확인을 해주세요.
+해결되면 comment 주세요.
|
코드 수정해서 다시 올렸습니당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.