Skip to content

Validation fault fix #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Validation fault fix #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae921ae
Add test for ValidationFault
lamflam Sep 20, 2022
7ba63a6
Handle ValidationFault type
lamflam Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ipp-v3-java-devkit/src/main/java/com/intuit/ipp/interceptors/HandleResponseInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ public void execute(IntuitMessage intuitMessage) throws FMSException {

if ("Validation".equalsIgnoreCase(fault.getType())) {
throw new ValidationException(fault.getError());
} else if ("ValidationFault".equalsIgnoreCase(fault.getType())) {
throw new ValidationException(fault.getError());
} else if ("Service".equalsIgnoreCase(fault.getType())) {
throw new ServiceException(fault.getError());
} else if ("AuthenticationFault".equalsIgnoreCase(fault.getType())) {
Expand Down
17 changes: 17 additions & 0 deletions ...-java-devkit/src/test/java/com/intuit/ipp/interceptors/HandleResponseInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,23 @@ public void testHandleResponseInterceptor_Validation() {
Assert.assertTrue(isValid);
}

@Test (enabled = false)
public void testHandleResponseInterceptor_ValidationFault() {
boolean isValid = false;
IntuitResponse intuitResponse = (IntuitResponse) intuitMessage.getResponseElements().getResponse();
intuitResponse.getFault().setType("ValidationFault");
HandleResponseInterceptor interceptor = new HandleResponseInterceptor();
try {
interceptor.execute(intuitMessage);
} catch (FMSException e) {
if (e instanceof ValidationException) {
isValid = true;
}
}

Assert.assertTrue(isValid);
}

@Test (enabled = false)
public void testHandleResponseInterceptor_Service() {
boolean isValid = false;
Expand Down