Fix not triggering rule no-dynamic-keys in non-vue files #637
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
no-dynamic-keys
rule isn't being triggered for.js
and.ts
files when used with the@vue/eslint-config-typescript
plugin. You can find a repository with a reproduction of this issue at https://github.com/mcler/no-dynamic-keys-reproduceSolution
Modified the rule implementation by adding a
compositingVisitors
function wrapper, following the approach used in theno-missing-keys
rule.