Skip to content

Fix not triggering rule no-dynamic-keys in non-vue files #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcler
Copy link

@mcler mcler commented Apr 23, 2025

Problem

The no-dynamic-keys rule isn't being triggered for .js and .ts files when used with the @vue/eslint-config-typescript plugin. You can find a repository with a reproduction of this issue at https://github.com/mcler/no-dynamic-keys-reproduce

Solution

Modified the rule implementation by adding a compositingVisitors function wrapper, following the approach used in the no-missing-keys rule.

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 4568014

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant