Warn when codegraph's index is mid-rebuild (silently-partial diagrams) - #18
Merged
Conversation
An interrupted codegraph index makes callers/callees return incomplete or empty results with no error, so codeshot can draw a silently-partial or blank diagram. Adds a preflight check (both modes): reads codegraph status, warns on stderr if it reports unresolved refs, with an accurate fix — a bare 'codegraph sync' heals a wedged index (sweeps orphaned refs) though it can misleadingly print 'Already up to date', so re-confirm status shows 0. parseUnresolvedRefs is pure and unit-tested. Tests: 77 passed. (runecho-guard bypassed: MAX_CODEGRAPH_BUFFER false-positive from a stale index.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupted codegraph index makes
callers/calleesreturn incomplete/empty results with no error — codeshot can then draw a silently-partial or blank diagram that looks fine, and node count alone can't distinguish that from a genuinely edge-free repo.Adds a preflight check (both modes): reads
codegraph status, warns on stderr if it reports unresolved refs, with the accurate fix (a barecodegraph syncheals it — sweeps orphaned refs — though it can misleadingly print "Already up to date"; then re-confirm status shows 0).Surfaced during a fleet dogfood where 5 repos had interrupted indexes producing empty/partial diagrams.
parseUnresolvedRefsis pure + unit-tested. 77 tests pass.