feat: added config.gatehub.organization_id and validation tests#367
Merged
feat: added config.gatehub.organization_id and validation tests#367
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Gatehub configuration surface area and Helm-side validation for the interledger-app/backend chart, aiming to fail fast when Gatehub integration is enabled but required settings are missing.
Changes:
- Introduces
config.gatehub.organization_idand maps it into the rendered ConfigMap asGATEHUB_ORGANIZATION_ID. - Adds a new
templates/validate.yamlgate to fail rendering whenconfig.gatehub.enabledis true and required Gatehub fields are empty. - Extends helm-unittest coverage to assert
GATEHUB_ORGANIZATION_IDis emitted when configured.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/interledger-app/backend/values.yaml | Adds Gatehub fields and configMap mapping for GATEHUB_ORGANIZATION_ID. |
| charts/interledger-app/backend/tests/deployment.server.configmaps_test.yaml | Adds a unit test asserting GATEHUB_ORGANIZATION_ID appears in the ConfigMap data. |
| charts/interledger-app/backend/templates/validate.yaml | New render-time validation that fails when Gatehub is enabled but required values are empty. |
| charts/interledger-app/backend/before.delme.yaml | Removes a large generated/output artifact file. |
raducristianpopa
approved these changes
Mar 6, 2026
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2026
Automated chart versioning after merge of PR #367. This PR updates Chart.yaml versions, packages updated charts into docs/interledger, and regenerates the Helm index. Co-authored-by: bosbaber <1615407+bosbaber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.gatehub.organization_idThis pull request adds stricter validation and configuration improvements for Gatehub integration in the Helm chart for the backend service. The main focus is to ensure that all required Gatehub configuration values are explicitly set when Gatehub integration is enabled, and to improve the handling and testing of these values.
Configuration validation and enforcement:
validate.yaml) that checks ifconfig.gatehub.enabledis true, and fails deployment if any required Gatehub configuration values (such asapi_base_url,organization_id, or client IDs) are missing or empty.Gatehub configuration updates:
values.yamlto explicitly include all required Gatehub configuration fields, includingenabled,organization_id, andcard_account_product_code, ensuring they are present and can be set per environment.GATEHUB_ORGANIZATION_IDto theconfigMapssection invalues.yaml, mapping the environment variable to the corresponding config value.Testing improvements:
deployment.server.configmaps_test.yamlto verify thatGATEHUB_ORGANIZATION_IDis correctly set in the generated ConfigMap when provided in the values.