Skip to content

Conversation

@Capncavedan
Copy link

Address deprecation warning about single-arity template handlers. This is the same as how the jbuilder project handled it.

DEPRECATION WARNING: Single arity template handlers are deprecated. Template handlers must
now accept two parameters, the view object and the source for the view object.
Change:
  >> #<ActionView::Template::Handlers::RJS:0x00007ff7621df338>.call(template)
To:
  >> #<ActionView::Template::Handlers::RJS:0x00007ff7621df338>.call(template, source)
 (called from <top (required)> at /Users/danb/.rvm/gems/ruby-2.5.7@exceedlms/bundler/gems/prototype-rails-e8dd3cd4e722/lib/prototype-rails/on_load_action_view.rb:24)

marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (0.9.2)
mimemagic (0.3.10)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to run bundle update mimemagic as several older versions have been yanked

@Capncavedan Capncavedan requested a review from aud-tree May 10, 2021 18:27
@Capncavedan
Copy link
Author

Capncavedan commented May 10, 2021

@aud-tree you've worked in this forked gem a bit - mind just giving this a quick look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants