-
Notifications
You must be signed in to change notification settings - Fork 57
[CI] Set read-all for workflows top-level token-permissions #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit reverts some changes introduced in d9b81b8. The changes: * Introduce some undocumented mechanism to enable/disable CI checks * Did not account that workflow might be triggered per schedule The changes can be reintroduced if 1) documented, 2) work properly. Fixes: d9b81b8 ("[CI] Set read-all for workflows top-level token-permissions (intel#1777)") Signed-off-by: Dmitry Rogozhkin <[email protected]>
@mengfei25 : this PR breaks accelerate and transformers tests scheduled to execute weekly:
The change you've introduced adds some mechanism to skip these tests, right? It does so based on commit/PR description? Unfortunately there is no any description provided to understand how it works. As such it's useless as can be used by limited number of people who knows how it works. Secondly, as I noted, it effectively breaks CI as it does not account on the scheduled workflows and handles only PRs. Further, the 1777 PR title says to add read-all permissions. Why does it adjust any workflows to add enable/disable mechanism? That's the change unrelated to the subject. Even if some workflows are long/failing/etc. for permissions unrelated reasons - we should not go and start enabling/disabling them. I think the right strategy in your case was to request an exception to merge the change on some failing cases in Accelerate/Transformers. You also could break that into 2 steps: modify all workflows except Accelerate/Transformers and then continue working (with me for example) to change the remaining 2. Overall, I strongly suggest that we need to revert some of the changes from PR 1777 for accelerate and transformers. Once done, you can reintroduce the fixed and described changes. Please, review: |
Fixed in #1846 |
disable_all