Skip to content

doc: improve readme #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

doc: improve readme #1732

merged 1 commit into from
Aug 29, 2025

Conversation

dvrogozh
Copy link
Contributor

@dvrogozh dvrogozh commented Jun 11, 2025 •
edited by chuanqi129
Loading

Fixes: #1731

disable_all

CC: @gajanan-choudhary, @EikanWang

@dvrogozh dvrogozh mentioned this pull request Jun 11, 2025
Closed
gajanan-choudhary
gajanan-choudhary reviewed Jun 11, 2025
View reviewed changes
gajanan-choudhary
gajanan-choudhary reviewed Jun 11, 2025
View reviewed changes
gajanan-choudhary
gajanan-choudhary suggested changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@gajanan-choudhary gajanan-choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response to #1731. Some fixes are needed, ready to approve once they are addressed.

@dvrogozh
Copy link
Contributor Author

@gajanan-choudhary : I addressed most of the comments (changes pushed), but still work on the few. Will update again today.

@dvrogozh dvrogozh force-pushed the docs branch 3 times, most recently from 4d6c8e1 to 72cbb0d Compare June 11, 2025 18:50
@dvrogozh
Copy link
Contributor Author

I addressed most of the comments (changes pushed), but still work on the few. Will update again today.

All done from my side. Please, review again.

@dvrogozh
Copy link
Contributor Author

@gajanan-choudhary, if you are ok with the last version, can you, please, approve PR?

gajanan-choudhary
gajanan-choudhary approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@gajanan-choudhary gajanan-choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for updating the image as well!

EikanWang
EikanWang reviewed Jun 17, 2025
View reviewed changes
@dvrogozh
Copy link
Contributor Author

@EikanWang, can you, please, review again. If you are ok, can we merge?

@dvrogozh
Copy link
Contributor Author

dvrogozh commented Jul 8, 2025

@EikanWang : are you ok to merge this version?

riverliuintel
riverliuintel reviewed Aug 28, 2025
View reviewed changes
@chuanqi129
Copy link
Contributor

Hi @dvrogozh please help to address @riverliuintel 's comments, after that we can land this PR

@dvrogozh dvrogozh force-pushed the docs branch 2 times, most recently from b38b367 to 1bca126 Compare August 28, 2025 18:48
@dvrogozh
Copy link
Contributor Author

Hi @dvrogozh please help to address @riverliuintel 's comments, after that we can land this PR

Addressed, dropped IPEX abbreviation.

@riverliuintel
Copy link
Contributor

Looks good

@chuanqi129 chuanqi129 enabled auto-merge August 29, 2025 03:16
@dvrogozh @gajanan-choudhary @chuanqi129
doc: improve readme
b5724ec 
Fixes: intel#1731

Signed-off-by: Dmitry Rogozhkin <[email protected]>
Co-authored-by: Gajanan Choudhary <[email protected]>
@chuanqi129 chuanqi129 disabled auto-merge August 29, 2025 03:27
@chuanqi129 chuanqi129 enabled auto-merge August 29, 2025 03:27
@chuanqi129 chuanqi129 added this pull request to the merge queue Aug 29, 2025
Merged via the queue into intel:main with commit 31d6aa1 Aug 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverliuintel riverliuintel riverliuintel left review comments

@EikanWang EikanWang EikanWang left review comments

@chuanqi129 chuanqi129 chuanqi129 approved these changes

+1 more reviewer

@gajanan-choudhary gajanan-choudhary gajanan-choudhary approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify README to help understand how this repository is integrated into PyTorch
5 participants
@dvrogozh @chuanqi129 @riverliuintel @EikanWang @gajanan-choudhary