fix: Add namespace variable to get_driver_info function for LinuxNetworkInterface object - #45
Open
KTokarze wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Improves network namespace propagation for Linux network interfaces so driver information can be retrieved in the correct namespace context.
Changes:
- Added a
namespacesetter toNetworkInterfaceso the namespace can be updated. - Updated driver info lookup to pass the interface namespace into
_ethtool.get_driver_information.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mfd_network_adapter/network_interface/linux.py | Adds a setter to allow updating the interface namespace. |
| mfd_network_adapter/network_interface/feature/driver/linux.py | Passes namespace into ethtool driver info retrieval. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KTokarze
force-pushed
the
get_driver_info_linux_namespace_fix
branch
3 times, most recently
from
March 9, 2026 09:42
cb60d18 to
edf00ac
Compare
…orkInterface object Signed-off-by: Kacper Tokarzewski <kacper.tokarzewski@intel.com>
KTokarze
force-pushed
the
get_driver_info_linux_namespace_fix
branch
from
March 20, 2026 15:02
edf00ac to
24d0a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how network interface namespaces are handled and passed through the codebase, particularly for retrieving driver information. The changes ensure that the namespace is correctly set and accessed, and that it is used when fetching driver details.
Namespace handling improvements:
namespaceproperty in theNetworkInterfaceclass, allowing the namespace to be updated as needed.Driver information retrieval:
_ethtool.get_driver_informationin theget_driver_infomethod to pass the interface's namespace, ensuring driver info is fetched within the correct network namespace context.