Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where network interfaces weren't being sorted naturally before applying index-based selection, which could lead to incorrect interface selection when interface names don't sort lexicographically (e.g., "eth1", "eth9", "eth10").
Key Changes:
- Added a
natural_keyfunction to properly sort interface names using natural sorting (treating numeric portions as integers) - Updated
_filter_interfaces_infoto sort interfaces before applying index-based selection - Added comprehensive test coverage for the natural sorting functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mfd_network_adapter/network_adapter_owner/base.py |
Introduced natural_key function and integrated natural sorting into interface filtering logic |
tests/unit/test_mfd_network_adapter/test_network_adapter_owner/test_network_owner_base.py |
Added tests verifying natural sorting behavior and index-based filtering with non-lexicographic interface names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
We don't publish DEVs .whl. |
Signed-off-by: Mateusz Chrominski <mateusz.chrominski@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.