[SYCL][Test E2E] Use %{build}/%{run} in Basic tests #9332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
commented
May 6, 2023
sergey-semenov
requested changes
May 8, 2023
aelovikov-intel
commented
May 8, 2023
Co-authored-by: Sergey Semenov <[email protected]>
sergey-semenov
approved these changes
May 8, 2023
|
CUDA fail is unrelated (the test hasn't been modified in this PR). I've pinged the author of #8747 as it's the most likely cause of the XPASS. The other fail on is unrelated as well because only SYCL E2E tests are modified in this PR. Normally, we'd need to fix the issue before merging this PR, but first revision of this PR passed Windows testing and the second was very minor. I think we can merge this PR with the current pre-commit CI coverage. I also think the SPIRV failure above is flaky, but hopefully the mention of it in this comment would make it easier to handle when/if it will happen in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.