[SYCL][Driver] Do not pass libsycl.so to host linker#22654
Merged
Conversation
Contributor
Author
|
I ran new offload model tests to be safe, they all passed (failures are unrelated) |
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
Contributor
Author
|
Hey @mdtoguchi, since @srividya-sundaram is out, can you please review this as soon as you get a chance? We need a new intel/llvm release with this issue fixed, so I'm hoping to get it merged soon. Hopefully the PR description provides enough info. Thanks |
mdtoguchi
approved these changes
Jul 16, 2026
mdtoguchi
left a comment
mdtoguchi
left a comment
Contributor
There was a problem hiding this comment.
Works for me. I'm sure the library location movement impacted the ability to resolve libsycl.so properly.
Contributor
Author
|
Yeah, probably I broke it somehow. Will take a look after I cherry pick this everywhere I need, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous compiler releases, we linked against
libsycl.sojust withStarting with upstream commit llvm/llvm-project#174877, we added what should be a path to
libsycl.so, resulting in the following in intel/llvm:So we do the same thing twice. Note we only do the
-lsyclpart in intel/llvm, that does not exist upstream.We have a bug report (CMPLRLLVM-76960) where the path resolution is failing, we compute an empty path, so we end up trying to link a bare
libsycl.sowith no path, which fails.Of course we should fix this, but I think the best solution is:
which has been working fine for years.
Separately, debug the failing
libsycl.sopath resolution and fix itRemove the
-lsycllogic which exists in intel/llvm so that we match upstream and only use the path tolibsycl.so, which upstream prefers.I am not doing 2) and 3) in this PR because we just released intel/llvm release 7.0.0 and we are going to need 7.0.1 because of this issue, so I don't want to delay it. I also need to cherry pick this internally ASAP.
After this is merged and cherry picked I will work on steps 2 and 3.
I checked Windows and we do not have a similar issue, so this is the only fix required.