Add exception header to ur_util.hpp#22649
Open
mccakit wants to merge 1 commit into
Open
Conversation
`ur_util.hpp` uses `std::exception_ptr` by value in `exceptionToResult()`, but only relies on a forward declaration transitively pulled in by another header. With this libc++/std combination, that transitive include of the full `<exception>` header no longer happens, so the type is incomplete at the point of use. ### Fix Add an explicit `#include <exception>` to `unified-runtime/source/common/ur_util.hpp` so `std::exception_ptr` is fully defined regardless of what other headers happen to pull in transitively. ### Testing Confirmed `ur_common` builds successfully with `clang++ -std=c++26` against the custom libc++ from LLVM upstream after the change.
bratpiorka
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ur_util.hppusesstd::exception_ptrby value inexceptionToResult(), but only relies on a forward declaration transitively pulled in by another header. With this libc++/std combination, that transitive include of the full<exception>header no longer happens, so the type is incomplete at the point of use.Fix
Add an explicit
#include <exception>tounified-runtime/source/common/ur_util.hppsostd::exception_ptris fully defined regardless of what other headers happen to pull in transitively.Testing
Confirmed
ur_commonbuilds successfully withclang++ -std=c++26against the custom libc++ from LLVM upstream after the change.