Skip to content

[SYCL][UR] Fix a crash when ZE_AFFINITY_MASK is invalid #22648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bratpiorka wants to merge 1 commit into
base: sycl
Choose a base branch
from
+36 −7
Draft

[SYCL][UR] Fix a crash when ZE_AFFINITY_MASK is invalid #22648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions unified-runtime/scripts/templates/ldrddi.cpp.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,25 @@ namespace ur_loader
if (*${th.make_pfn_name(n, tags, obj)} == nullptr)
return ${X}_RESULT_ERROR_UNINITIALIZED;

uint32_t adapter;
ur_adapter_handle_t *adapterHandle = numAdapters < NumEntries ? &${obj['params'][1]['name']}[numAdapters] : nullptr;
${th.make_pfn_name(n, tags, obj)}( 1, adapterHandle, &adapter );
// Count adapters without writing handles when the caller did not request
// them or its output array is already full.
if (${obj['params'][1]['name']} == nullptr || numAdapters >= NumEntries) {
uint32_t adapter = 0;
auto result = ${th.make_pfn_name(n, tags, obj)}( 0, nullptr, &adapter );
if (result == ${X}_RESULT_SUCCESS)
numAdapters += adapter;
continue;
}

// Query single adapter into a temporary handle and copy it to output array
// if the query was successful.
uint32_t adapter = 0;
ur_adapter_handle_t adapterHandle = nullptr;
auto result = ${th.make_pfn_name(n, tags, obj)}( 1, &adapterHandle, &adapter );
if (result != ${X}_RESULT_SUCCESS || adapterHandle == nullptr)
continue;

${obj['params'][1]['name']}[numAdapters] = adapterHandle;
numAdapters += adapter;
}

Expand Down
22 changes: 18 additions & 4 deletions unified-runtime/source/loader/ur_ldrddi.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading