[SYCL][AMDGPU] Use uint64_t type for SYCLReqdWorkGroupSize product type#22622
Merged
uditagarwal97 merged 2 commits intoJul 20, 2026
Conversation
range::size() is product of its dimensions and its return type is size_t. SYCLReqdWorkGroupSize product probably should fit in size_t type. unsigned type may have overflow issue when size_t type size is 64bit. Use uint64_t to align with downstream code.
Fznamznon
reviewed
Jul 14, 2026
Fznamznon
left a comment
Fznamznon
left a comment
Contributor
There was a problem hiding this comment.
Is there any test that could show a need for the change?
Contributor
Author
done, added a test that fails without this PR |
Fznamznon
approved these changes
Jul 17, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
range::size() is product of its dimensions and its return type is size_t. SYCLReqdWorkGroupSize product probably should fit in size_t type. unsigned type may have overflow issue when size_t type size is 64bit. Use uint64_t to align with downstream code.