[DRAFT] [UR] Add new urKernelGetSuggestedLocalWorkSizeWithArgs() API#21442
Draft
ldorau wants to merge 4 commits intointel:syclfrom
Draft
[DRAFT] [UR] Add new urKernelGetSuggestedLocalWorkSizeWithArgs() API#21442ldorau wants to merge 4 commits intointel:syclfrom
ldorau wants to merge 4 commits intointel:syclfrom
Conversation
ldorau
changed the title
ldorau
force-pushed
the
Add_urKernelGetSuggestedLocalWorkSizeWithArgs_API
branch
from
a8fb016 to
ef1a5b8
Compare
sarnex
pushed a commit
that referenced
this pull request
Mar 4, 2026
Change ordinals of two files: - unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml - unified-runtime/scripts/core/kernel.yml The following files have to be in the following order now: ordinal "10" - unified-runtime/scripts/core/enqueue.yml ordinal "11" - unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml ordinal "12" - unified-runtime/scripts/core/kernel.yml because we will add a new `urKernelGetSuggestedLocalWorkSizeWithArgs()` API (see #21442) to `kernel.yml` that uses `ur_exp_kernel_arg_properties_t` which is defined in `exp-enqueue-kernel-launch-with-args.yml`, but `exp-enqueue-kernel-launch-with-args.yml` uses `ur_kernel_launch_ext_properties_t` which is defined in `enqueue.yml`. Ref: #21442 --------- Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_urKernelGetSuggestedLocalWorkSizeWithArgs_API
branch
2 times, most recently
from
35f3698 to
3f00063
Compare
Contributor
Author
|
@zhaomaosu could you review the sanitizer changes? |
ldorau
force-pushed
the
Add_urKernelGetSuggestedLocalWorkSizeWithArgs_API
branch
2 times, most recently
from
c997fa5 to
6ecfe1e
Compare
Contributor
Author
|
Rebased, because #21290 has been merged |
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…code) Commit output of make generate. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
…) API urKernelGetSuggestedLocalWorkSizeWithArgs() has to call urKernelGetSuggestedLocalWorkSize() only for now, because its full implementation requires more changes in the sanitizers' layer, what will be implemented in the following pull requests. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Use urKernelGetSuggestedLocalWorkSizeWithArgs() in sanitizers' intercept functions for urEnqueueKernelLaunchWithArgsExp(). Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.