Skip to content

[UR][L0v2] Fix graph capture and tests with out-of-order queues#21428

Open
mmichel11 wants to merge 2 commits intointel:syclfrom
adamfidel:matt/ur_oooq_graph
Open

[UR][L0v2] Fix graph capture and tests with out-of-order queues#21428
mmichel11 wants to merge 2 commits intointel:syclfrom
adamfidel:matt/ur_oooq_graph

Conversation

@mmichel11
Copy link
Contributor

Fixes out-of-order queue issues discovered during SYCL graph testing:

  • Performing a queue operation followed by a graph capture would begin and end capture on separate command lists. This is because getNextCommandListId() is called before the command list actually begins recording. We now directly use captureCmdListManagerIdx which also removes extra L0 is capturing calls.
  • Out-of-order queue testing was being silently skipped because we inherited uur::urQueueTest in the test fixture which hardcodes 0 as the queue flag. Inheriting uur::urMultiQueueTypeTest instead uses the provided parameter to set the out-of-order queue flag.

@mmichel11
Copy link
Contributor Author

Closing, there are other things that need to be addressed for out-of-order queue support with graphs.

@mmichel11 mmichel11 closed this Mar 4, 2026
@mmichel11
Copy link
Contributor Author

This capture issue can be fixed now and fork-join with out-of-order queue will be fixed separately.

Please note that out-of-order queue testing is still skipped with the fork-join is capturing test. Since fork-join has issues with out-of-order queues, I think it should be resolved with that PR.

@mmichel11 mmichel11 reopened this Mar 5, 2026
@mmichel11 mmichel11 marked this pull request as ready for review March 5, 2026 16:25
@mmichel11 mmichel11 requested review from a team as code owners March 5, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant