[UR][L0v2] Fix graph capture and tests with out-of-order queues#21428
Open
mmichel11 wants to merge 2 commits intointel:syclfrom
Open
[UR][L0v2] Fix graph capture and tests with out-of-order queues#21428mmichel11 wants to merge 2 commits intointel:syclfrom
mmichel11 wants to merge 2 commits intointel:syclfrom
Conversation
Contributor
Author
|
Closing, there are other things that need to be addressed for out-of-order queue support with graphs. |
Contributor
Author
|
This capture issue can be fixed now and fork-join with out-of-order queue will be fixed separately. Please note that out-of-order queue testing is still skipped with the fork-join is capturing test. Since fork-join has issues with out-of-order queues, I think it should be resolved with that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes out-of-order queue issues discovered during SYCL graph testing:
getNextCommandListId()is called before the command list actually begins recording. We now directly usecaptureCmdListManagerIdxwhich also removes extra L0 is capturing calls.uur::urQueueTestin the test fixture which hardcodes 0 as the queue flag. Inheritinguur::urMultiQueueTypeTestinstead uses the provided parameter to set the out-of-order queue flag.