[SYCL] Use global_var_host_access ext for device_global on SPIR-V#21351
[SYCL] Use global_var_host_access ext for device_global on SPIR-V#21351Maetveis wants to merge 2 commits intointel:syclfrom
Conversation
Change the lowering of the `sycl-host-access` attribute to use the `SPV_INTEL_global_variable_host_access` extension instead of the deprecated `SPV_INTEL_global_variable_decorations` extension. Newly compiled applications will need to use a recent version of IGC that supports the new extension, but IGC has implemented the support for the new extension more than 6 months ago (in version 2.16.0), so I believe this is ok to do now.
These Windows failures seem related I'm looking into them. |
Yep, all of these use |
YuriPlyakhin
left a comment
There was a problem hiding this comment.
Changes in files owned by me look good.
Not sure about when is the good time to merge the PR, since it will break customers, if they are using older GPU drivers.
Thanks for the review!
I didn't find any info on backwards compatibility with the driver for the Open Source (this) repository, the closest I could find was Intel® oneAPI Base Toolkit System Requirements. Here at least for linux the required driver versions would be recent enough, I think:
This is for the developer tools, while this PR adds a requirement for the runtime system. Also the same page doesn't have the same info for Windows 🤷. I do have some work internally that depends on this, but if we can't merge it yet I can cherry pick only the function |
Change the lowering of the
sycl-host-accessattribute to use theSPV_INTEL_global_variable_host_accessextension instead of the deprecatedSPV_INTEL_global_variable_decorationsextension.Newly compiled applications will need to use a recent version of IGC that supports the new extension, but IGC has implemented the support for the new extension more than 6 months ago (in version 2.16.0), so I believe this is ok to do now.