[SYCL[E2E] Enable Basic/image tests #20959
Merged
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszpn
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
force-pushed
the
fix-bas-tests
branch
from
b9d047a to
19727b3
Compare
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
force-pushed
the
fix-bas-tests
branch
from
19727b3 to
072dfa0
Compare
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
force-pushed
the
fix-bas-tests
branch
from
072dfa0 to
a8efae5
Compare
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
changed the title
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-reviewers-runtime This is kind invitation to review |
uditagarwal97
approved these changes
Jan 27, 2026
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM. Please update the corresponding Github issues, either close them or update their description, if the PR doesn't fully address the issue.
Contributor
|
@intel/llvm-gatekeepers please consider merging |
|
|
||
| // Test flakily fails on PVC and BMG. | ||
| // UNSUPPORTED: arch-intel_gpu_pvc || arch-intel_gpu_bmg_g21 | ||
| // UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16401 |
Contributor
There was a problem hiding this comment.
Could you please clarify, does "We no longer support opencl:gpu" mean "we won't fix it"?
In this case, I'd say it might be better to mark this test as:
// UNSUPPORTED: opencl && (arch-intel_gpu_pvc || arch-intel_gpu_bmg_g21)
// UNSUPPORTED-INTENDED: *justification*
Just in case it's launched locally / internally.
UPD. BTW we still test PVC & opencl:gpu in pre-commit, so if it wasn't fixed, it will appear again.
Contributor
Author
There was a problem hiding this comment.
It was my mistake, I will verify the accessor test again before merge and re-consider the modification. Thanks
Contributor
Author
There was a problem hiding this comment.
@KornevNikita I reproduced the bug on opencl:gpu as described in tracker, so fixed the test. Thanks again for being watchful.
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
approved these changes
Jan 28, 2026
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mateuszpn
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers This is ready for merge |
KornevNikita
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests no longer fail.
The accessor.cpp test was reported to fail only with opencl:gpu device
The image/ tests pass locally and in CI