[SYCL] Implement sycl_ext_oneapi_usm_shortcuts #20911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
HPS-1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
KornevNikita
left a comment
KornevNikita
left a comment
There was a problem hiding this comment.
SYCL_EXT_ONEAPI_USM_SHORTCUTS isn't defined yet, right?
Signed-off-by: Hu, Peisen <[email protected]>
HPS-1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
Yup added that. TY! |
Signed-off-by: Hu, Peisen <[email protected]>
HPS-1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
approved these changes
Jan 6, 2026
gmlueck
reviewed
Jan 6, 2026
Contributor
There was a problem hiding this comment.
If this PR fully implements the extension, please also move it to the "experimental" folder and update the Status section.
| #include <cassert> | ||
|
|
||
| using namespace sycl; | ||
| using namespace sycl::ext::oneapi::experimental; |
Contributor
There was a problem hiding this comment.
Do we normally add using namespace to our tests? I thought that was generally considered bad practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension's specification can be found here: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_usm_shortcuts.asciidoc