Skip to content

Conversation

@slawekptak
Copy link
Contributor

Extract the range rounding logic to a separate header, so it can be used in both the handler and the queue (once the handler-less kernel submission logic uses range rounding).

Extract the range rounding logic to a separate header,
so it can be used in both the handler and the queue (once
the handler-less kernel submission logic uses range rounding).
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extracts range rounding logic from the handler class into a new separate header file (range_rounding.hpp) to enable code reuse. The refactoring prepares for handler-less kernel submission by making the range rounding utilities available to both handler and queue implementations.

Key Changes

  • Creates new sycl/include/sycl/range_rounding.hpp header containing extracted range rounding classes and functions
  • Moves range rounding logic from handler member functions to standalone functions in the detail namespace
  • Updates ABI symbol exports to reflect the namespace change from handler:: to detail::

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sycl/include/sycl/range_rounding.hpp New header containing extracted range rounding utilities including RoundedRangeIDGenerator, RoundedRangeKernel classes, and helper functions
sycl/include/sycl/handler.hpp Removes range rounding implementation, includes new header, and updates calls to use detail:: namespace functions
sycl/source/handler.cpp Removes range rounding function implementations and adds get_device() accessor method
sycl/source/queue.cpp Implements extracted range rounding functions in detail namespace
sycl/test/abi/sycl_symbols_linux.dump Updates exported symbols to reflect namespace changes
sycl/test/abi/sycl_symbols_windows.dump Updates exported symbols to reflect namespace changes
sycl/test/include_deps/*.cpp Updates include dependency tests to verify new header is included

@slawekptak slawekptak marked this pull request as ready for review December 16, 2025 13:11
@slawekptak slawekptak requested a review from a team as a code owner December 16, 2025 13:11
@slawekptak
Copy link
Contributor Author

@intel/llvm-gatekeepers Failure of the FreeFunctionKernels/structs_with_special_types_as_kernel_paramters.cpp test is unrelated (20824 has been identified as the cause). Please consider merging this PR. Thanks.

@sarnex sarnex merged commit f6cd900 into intel:sycl Dec 16, 2025
51 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants