[CI][benchmarks] Modify benchmark scripts and CI workflow to enable gdb_mode #20891
Conversation
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
56320bf to
9de028f
Compare
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
9de028f to
42f6390
Compare
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
42f6390 to
e179b9f
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
e179b9f to
1cae956
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
1cae956 to
a4c9fed
Compare
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
luszczewskakasia1
force-pushed
the
luszczewskakasia1_add-gdb
branch
from
a4c9fed to
c2805eb
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…ugging benchmarks
| default: '' | ||
| gdb_mode: | ||
| type: string | ||
| required: False |
There was a problem hiding this comment.
pls add default = false
| Extra options to be added to LIT_OPTS. | ||
| type: string | ||
| default: '' | ||
| gdb_mode: |
There was a problem hiding this comment.
pls move below and add to the name prefix benchmark_
| echo "::endgroup::" | ||
| echo "::group::run_benchmarks" | ||
| export LLVM_BENCHMARKS_USE_GDB=${LLVM_BENCHMARKS_USE_GDB} |
There was a problem hiding this comment.
when is LLVM_BENCHMARKS_USE_GDB set?
| if is_gdb_benchmarks: | ||
| return [(0.0, 0.0)] | ||
|
|
||
| else: |
There was a problem hiding this comment.
no need for else, since you returned on the if (this way we don't need extra tab for the rest of the code
| f"-DUSE_SYSTEM_LEVEL_ZERO=OFF", | ||
| f"-DCMAKE_CXX_COMPILER=clang++", | ||
| f"-DCMAKE_C_COMPILER=clang", | ||
| f"-DCMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG -fdebug-info-for-profiling", |
There was a problem hiding this comment.
perhaps we should only add these when GDB is enabled...?
| command = command.split() | ||
|
|
||
| is_gdb_benchmarks = os.environ.get("LLVM_BENCHMARKS_USE_GDB", "") == "true" | ||
| if command[0] == "taskset" and is_gdb_benchmarks: |
There was a problem hiding this comment.
why do we check if taskset is the first part of the command?
There was a problem hiding this comment.
I did it so gdb is used only for commands which are responsible for running benchmarks as it looks like that 'taskset', '-c', '0,1,2,3', '/tmp/tmp7nhle4ge/compute-benchmarks-build/bin/torch_benchmark_l0', '--test=KernelSubmitMultiQueue', '--csv', '--noHeaders', '--iterations=3', '--workgroupCount=4096', '--workgroupSize=512', '--kernelsPerQueue=20'
I don't think we need gdb for any other command which are executed in out benchmarks as this extends time of execution of the script.
There was a problem hiding this comment.
can it be not the first one? e.g. in command like PATH=<...> taskset <...>? just asking, dunno.
| f"-DCMAKE_CXX_COMPILER=clang++", | ||
| f"-DCMAKE_C_COMPILER=clang", | ||
| f"-DCMAKE_CXX_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG -fdebug-info-for-profiling", | ||
| f"-DCMAKE_BUILD_TYPE=RelWithDebInfo", |
There was a problem hiding this comment.
Modify the GitProject class, there is a default Release version set for all projects.
Modify benchmark scripts and CI workflow to enable gdb_mode on workflow_dispatch while deugging benchmarks.