[SYCL] Make sycl::device use raw device_impl * for its impl
#20821
+141
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
requested review from
KseniyaTikhomirova,
reble,
sergey-semenov,
slawekptak and
steffenlarsen
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
commented
Dec 3, 2025
Contributor
Author
There was a problem hiding this comment.
Changes to add explicit detail:: are related to #20820, caused by not including sycl::detail namespace into sycl::device's ADL because of the dropped inheritance.
Comment on lines
+33
to
+46
| platform_impl::platform_impl(ur_platform_handle_t APlatform, | ||
| adapter_impl &Adapter) | ||
| : MPlatform(APlatform), MAdapter(&Adapter) { | ||
|
|
||
| // Find out backend of the platform | ||
| ur_backend_t UrBackend = UR_BACKEND_UNKNOWN; | ||
| Adapter.call_nocheck<UrApiKind::urPlatformGetInfo>( | ||
| APlatform, UR_PLATFORM_INFO_BACKEND, sizeof(ur_backend_t), &UrBackend, | ||
| nullptr); | ||
| MBackend = convertUrBackend(UrBackend); | ||
| } | ||
|
|
||
| platform_impl::~platform_impl() = default; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Needed to move to .cpp because it now needs a "complete" device_impl type for MDevices.
`device_impl`s are owned by the parent platforms and are only destroyed when SYCL RT is unloaded. As such, there is no reason to pay the price of a `std::shared_ptr` a raw non-owning pointers is enough. Use a pointer and not a reference because `sycl::device` is assignable.
aelovikov-intel
force-pushed
the
raw-device_impl
branch
from
070d79a to
1b0dc36
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 3, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 4, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 4, 2025
slawekptak
approved these changes
Dec 15, 2025
Contributor
|
@intel/sycl-graphs-reviewers @reble @KseniyaTikhomirova @sergey-semenov @steffenlarsen A gentle ping for review. Thanks! |
steffenlarsen
added
the
abi-break
steffenlarsen
approved these changes
Dec 15, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
This LGTM, but beware that it will change ABI in a way that is likely to affect a lot of applications. ABI window is open, but better be aware.
adamfidel
approved these changes
Dec 15, 2025
Member
adamfidel
left a comment
adamfidel
left a comment
There was a problem hiding this comment.
The change to the CommandGraph unit test looks good to me.
Contributor
|
@intel/llvm-gatekeepers Please consider merging. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@intel/llvm-gatekeepers, this PR breaks pre-/post-commit CI on Windows. |
Contributor
Here's the fix: #20902 |
This was referenced Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_impls are owned by the parent platforms and are only destroyed when SYCL RT is unloaded. As such, there is no reason to pay the price of astd::shared_ptr, a raw non-owning pointers is enough.Use a pointer and not a reference because
sycl::deviceis assignable.