-
Notifications
You must be signed in to change notification settings - Fork 791
[CI] Re-enable zstd
in CI
#20381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[CI] Re-enable zstd
in CI
#20381
Conversation
python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \ | ||
-s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \ | ||
--ci-defaults --hip --cuda \ | ||
--ci-defaults --use-zstd --hip --cuda \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to move this to --ci-defaults? or something like:
if args.use_zstd or args.ci_defaults::
llvm_enable_zstd = "FORCE_ON"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--ci-defaults
is used in sycl-web and the runners used in sycl-web testing don't have zstd installed. I did try moving it to --ci-defaults
in the past, but that ended up breaking pulldown testing. For reference: #15840
Test d:\github_work\llvm\llvm\build-e2e\reduction\output\reduction_ctor.cpp.tmp.out hung! on Win BMG, unclear if actually related tho |
418d938
to
248e957
Compare
zstd
got disable in CI by a bad merge in 9e1505cThis PR re-enables
zstd
in CI.