Fixing Coverity copy/move issue #19452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
requested changes
Jul 16, 2025
xptifw/include/xpti_string_table.hpp
Outdated
| @@ -71,8 +71,7 @@ class StringTable { | |||
| if (!str) | |||
| return xpti::invalid_id<xpti::string_id_t>; | |||
|
|
|||
| std::string LocalStr = str; | |||
| return add(LocalStr, ref_str); | |||
| return add(std::move(str), ref_str); | |||
There was a problem hiding this comment.
Suggested change
| return add(std::move(str), ref_str); | |
| return add(std::string(str), ref_str); |
Otherwise, this looks like it will result in infinite recursion.
xptifw/src/xpti_trace_framework.cpp
Outdated
Comment on lines
1576
to
1581
| auto Acc = StreamCBs.find(TraceType); | ||
| if (Acc == StreamCBs.end()) { | ||
| // Create a new slot and return the accessor for the trace type | ||
| auto Tmp = StreamCBs[TraceType]; | ||
| auto& Tmp = StreamCBs[TraceType]; | ||
| Acc = StreamCBs.find(TraceType); | ||
| } |
There was a problem hiding this comment.
This whole block of code seems equivalent to just auto &Acc = StreamCBs[TraceType];, assuming Acc->second is changed to Acc below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue