[SYCL] reset enqueue status so that buffer can be used after failure is addressed #17871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-enqueued. But many errors/exceptions are addressable and operations should be able to resume after. The fix here is straightforward. We also improve the FailedDependency unit test.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
ping to reviewers @sergey-semenov |
Contributor
sergey-semenov
left a comment
sergey-semenov
left a comment
There was a problem hiding this comment.
I don't think I have any issues with this, but I'd like @KseniyaTikhomirova to have a look as well.
cperkinsintel
added a commit
to cperkinsintel/llvm
that referenced
this pull request
Apr 25, 2025
…failure is addressed (intel#17871)" This reverts commit a827836. Signed-off-by: Chris Perkins <[email protected]>
againull
pushed a commit
that referenced
this pull request
Apr 25, 2025
reverting "[SYCL] reset enqueue status so that buffer can be used after …failure is addressed (#17871)" This PR accidentally introduced a very subtle flaky failure/seg fault. I quickly tried the immediate and obvious fixes but no luck. Given that the original problem is lower priority, I'm reverting the commit before we cement in the instability. Addresses issue: #17965 This reverts commit a827836. Signed-off-by: Chris Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMPLRLLVM-65738 - If we run out of memory, an exception is thrown and can be caught by the user application. They can address this in several ways: free memory, .wait() on outstanding operations, etc. But despite addressing the problem, SYCL has a bug wherein the buffer is not usable. This is because the EnqueueStatus isn't reset, the Command/Requirement cannot be re-enqueued.
The fix here is straightforward. We also improve the FailedDependency unit test.