[SYCL] reset enqueue status so that buffer can be used after failure is addressed #17871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-enqueued. But many errors/exceptions are addressable and operations should be able to resume after. The fix here is straightforward. We also improve the FailedDependency unit test.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMPLRLLVM-65738 - If we run out of memory, an exception is thrown and can be caught by the user application. They can address this in several ways: free memory, .wait() on outstanding operations, etc. But despite addressing the problem, SYCL has a bug wherein the buffer is not usable. This is because the EnqueueStatus isn't reset, the Command/Requirement cannot be re-enqueued.
The fix here is straightforward. We also improve the FailedDependency unit test.