Skip to content

Revert unexpected test changes #17864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ llvm/include/llvm/SYCLLowerIR/SYCLCreateNVVMAnnotations.h @intel/llvm-reviewers-
llvm/lib/SYCLLowerIR/SYCLCreateNVVMAnnotations.cpp @intel/llvm-reviewers-cuda
llvm/lib/Target/NVPTX @intel/llvm-reviewers-cuda
llvm/lib/Target/AMDGPU @intel/llvm-reviewers-cuda
unified-runtime/source/common/cuda-hip @intel/llvm-reviewers-cuda

# XPTI instrumentation utilities
xpti/ @intel/llvm-reviewers-runtime
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sycl-linux-precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ on:
- '.github/workflows/sycl-macos-*.yml'
- '.github/workflows/sycl-nightly.yml'
- '.github/workflows/sycl-rel-nightly.yml'
- '.github/workflows/trivy.yml'
- 'devops/containers/**'
- 'devops/actions/build_container/**'

Expand Down
34 changes: 23 additions & 11 deletions .github/workflows/sycl-rel-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
with:
build_cache_root: "/__w/"
build_artifact_suffix: default
build_configure_extra_args: '--hip --cuda'
build_configure_extra_args: '--no-assertions --add_security_flags=sanitize --hip --cuda'
build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest
build_ref: ${{ inputs.testing_branch || 'sycl-rel-6_1_0' }}

Expand All @@ -63,34 +63,35 @@ jobs:
runner: '["Linux", "amdgpu"]'
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
target_devices: hip:gpu
tests_selector: e2e

- name: Intel L0 GPU
- name: Intel L0 Gen12 GPU
runner: '["Linux", "gen12"]'
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
target_devices: level_zero:gpu
tests_selector: e2e
extra_lit_opts: --param gpu-intel-gen12=True

- name: Intel OCL GPU
- name: Intel L0 Battlemage GPU
runner: '["Linux", "bmg"]'
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
target_devices: level_zero:gpu

- name: Intel OCL Gen12 GPU
runner: '["Linux", "gen12"]'
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
target_devices: opencl:gpu
tests_selector: e2e
extra_lit_opts: --param gpu-intel-gen12=True

- name: Intel OCL CPU
runner: '["Linux", "gen12"]'
image_options: -u 1001 --privileged --cap-add SYS_ADMIN
target_devices: opencl:cpu
tests_selector: e2e
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix.runner }}
image_options: ${{ matrix.image_options }}
target_devices: ${{ matrix.target_devices }}
tests_selector: ${{ matrix.tests_selector }}
tests_selector: e2e
extra_lit_opts: ${{ matrix.extra_lit_opts }}
repo_ref: ${{ inputs.testing_branch || 'sycl-rel-6_1_0' }}
devops_ref: sycl
Expand All @@ -104,6 +105,7 @@ jobs:
uses: ./.github/workflows/sycl-windows-build.yml
with:
ref: ${{ inputs.testing_branch || 'sycl-rel-6_1_0' }}
build_configure_extra_args: '--no-assertions --add_security_flags=sanitize'

# We upload both Linux/Windows build via Github's "Releases"
# functionality, make sure Linux/Windows names follow the same pattern.
Expand All @@ -116,12 +118,22 @@ jobs:
always()
&& !cancelled()
&& needs.build-win.outputs.build_conclusion == 'success'
strategy:
fail-fast: false
matrix:
include:
- name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
# 6_1_0 doesn't support the auto-detection, keep it until 6_2_0.
extra_lit_opts: --param gpu-intel-gen12=True
- name: Intel Battlemage Graphics with Level Zero
runner: '["Windows","bmg"]'
uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
name: ${{ matrix.name }}
runner: ${{ matrix.runner }}
sycl_toolchain_archive: ${{ needs.build-win.outputs.artifact_archive_name }}
extra_lit_opts: --param gpu-intel-gen12=True
extra_lit_opts: ${{ matrix.extra_lit_opts }}
repo_ref: ${{ inputs.testing_branch || 'sycl-rel-6_1_0' }}
devops_ref: sycl

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sycl-windows-precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
- '.github/workflows/sycl-macos-*.yml'
- '.github/workflows/sycl-nightly.yml'
- '.github/workflows/sycl-rel-nightly.yml'
- '.github/workflows/trivy.yml'
- 'devops/containers/**'
- 'devops/actions/build_container/**'

Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/sycl-windows-run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,14 @@ jobs:
echo "C:\Program Files\Git\usr\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: Register cleanup after job is finished
uses: ./devops/actions/cleanup
- uses: ./devops/actions/cached_checkout
- uses: actions/checkout@v4
if: inputs.tests_selector == 'e2e'
with:
path: llvm
ref: ${{ inputs.repo_ref || github.sha }}
cache_path: "D:\\\\github\\\\_work\\\\repo_cache\\\\"
sparse-checkout: |
llvm/utils/lit
sycl/test-e2e
- name: Download compiler toolchain
uses: actions/download-artifact@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/trivy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
run: ./bin/trivy config --format json --output trivy-report.json --ignorefile=devops/.trivyignore.yaml devops/containers --exit-code 1

- name: Upload report artifact
if: always() && !cancelled()
uses: actions/upload-artifact@v4
with:
name: trivy-report
Expand Down
4 changes: 2 additions & 2 deletions clang/test/CodeGenSYCL/sub-group-size.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ using namespace sycl;
// ALL-DAG: define {{.*}}spir_func void @{{.*}}external_10{{.*}}() #{{[0-9]+}}{{.*}} !intel_reqd_sub_group_size ![[TEN:[0-9]+]]

SYCL_EXTERNAL void external_default_behavior() {}
// NONE-DAG: define {{.*}}spir_func void @{{.*}}external_default_behavior{{.*}}() #{{[0-9]+}} !srcloc !{{[0-9]+}} !sycl_fixed_targets !{{[0-9]+}} {
// NONE-DAG: define {{.*}}spir_func void @{{.*}}external_default_behavior{{.*}}() #{{[0-9]+}} !sycl_fixed_targets !{{[0-9]+}} {
// PRIM_DEF-DAG: define {{.*}}spir_func void @{{.*}}external_default_behavior{{.*}}() #{{[0-9]+}}{{.*}} !intel_reqd_sub_group_size ![[PRIMARY]]
// TEN_DEF-DAG: define {{.*}}spir_func void @{{.*}}external_default_behavior{{.*}}() #{{[0-9]+}}{{.*}} !intel_reqd_sub_group_size ![[TEN]]

void default_behavior() {
kernel_single_task<class Kernel1>([]() {
});
}
// NONE-DAG: define {{.*}}spir_kernel void @{{.*}}Kernel1() #{{[0-9]+}} !srcloc !{{[0-9]+}} !kernel_arg_buffer_location !{{[0-9]+}} !sycl_fixed_targets !{{[0-9]+}} {
// NONE-DAG: define {{.*}}spir_kernel void @{{.*}}Kernel1() #{{[0-9]+}} !kernel_arg_buffer_location !{{[0-9]+}} !sycl_fixed_targets !{{[0-9]+}} {
// PRIM_DEF-DAG: define {{.*}}spir_kernel void @{{.*}}Kernel1() #{{[0-9]+}}{{.*}} !intel_reqd_sub_group_size ![[PRIMARY]]
// TEN_DEF-DAG: define {{.*}}spir_kernel void @{{.*}}Kernel1() #{{[0-9]+}}{{.*}} !intel_reqd_sub_group_size ![[TEN]]

Expand Down
6 changes: 4 additions & 2 deletions devops/actions/run-tests/e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ runs:
using: "composite"
steps:
- name: Checkout E2E tests
uses: ./devops/actions/cached_checkout
uses: actions/checkout@v4
with:
path: llvm
ref: ${{ inputs.ref || github.sha }}
cache_path: "/__w/repo_cache/"
sparse-checkout: |
llvm/utils/lit
sycl/test-e2e

- name: Download E2E Binaries
if: inputs.testing_mode == 'run-only'
Expand Down
8 changes: 4 additions & 4 deletions devops/dependencies-igc-dev.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"linux": {
"igc_dev": {
"github_tag": "igc-dev-81b4de2",
"version": "81b4de2",
"updated_at": "2025-03-29T17:38:03Z",
"url": "https://api.github.com/repos/intel/intel-graphics-compiler/actions/artifacts/2844658814/zip",
"github_tag": "igc-dev-b74b7ab",
"version": "b74b7ab",
"updated_at": "2025-04-02T18:41:33Z",
"url": "https://api.github.com/repos/intel/intel-graphics-compiler/actions/artifacts/2869865189/zip",
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu"
}
}
Expand Down
7 changes: 7 additions & 0 deletions devops/scripts/benchmarks/benches/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,20 @@ def unstable(self) -> str:
def get_tags(self) -> list[str]:
return []

def range(self) -> tuple[float, float]:
return None

def get_metadata(self) -> BenchmarkMetadata:
range = self.range()

return BenchmarkMetadata(
type="benchmark",
description=self.description(),
notes=self.notes(),
unstable=self.unstable(),
tags=self.get_tags(),
range_min=range[0] if range else None,
range_max=range[1] if range else None,
)


Expand Down
12 changes: 7 additions & 5 deletions devops/scripts/benchmarks/benches/compute.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def additionalMetadata(self) -> dict[str, BenchmarkMetadata]:
"The UR v2 adapter noticeably reduces UR layer overhead, also improving SYCL performance.\n"
"Work is ongoing to reduce the overhead of the SYCL API\n",
tags=["submit", "micro", "SYCL", "UR", "L0"],
range_min=0.0,
),
"SinKernelGraph": BenchmarkMetadata(
type="group",
Expand Down Expand Up @@ -294,11 +295,9 @@ def name(self):
return f"api_overhead_benchmark_{self.runtime.value} SubmitKernel {order}{completion_str}"

def explicit_group(self):
return (
"SubmitKernel"
if self.measure_completion == 0
else "SubmitKernel With Completion"
)
order = "In Order" if self.ioq else "Out Of Order"
completion_str = " With Completion" if self.measure_completion else ""
return f"SubmitKernel {order}{completion_str}"

def description(self) -> str:
order = "in-order" if self.ioq else "out-of-order"
Expand All @@ -317,6 +316,9 @@ def description(self) -> str:
f"Runs 10 simple kernels with minimal execution time to isolate API overhead from kernel execution time. {l0_specific}"
)

def range(self) -> tuple[float, float]:
return (0.0, None)

def bin_args(self) -> list[str]:
return [
f"--Ioq={self.ioq}",
Expand Down
5 changes: 5 additions & 0 deletions devops/scripts/benchmarks/history.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,18 @@ def create_run(self, name: str, results: list[Result]) -> BenchmarkRun:
git_hash = "unknown"
github_repo = None

compute_runtime = (
options.compute_runtime_tag if options.build_compute_runtime else None
)

return BenchmarkRun(
name=name,
git_hash=git_hash,
github_repo=github_repo,
date=datetime.now(tz=timezone.utc),
results=results,
hostname=socket.gethostname(),
compute_runtime=compute_runtime,
)

def save(self, save_name, results: list[Result], to_file=True):
Expand Down
4 changes: 4 additions & 0 deletions devops/scripts/benchmarks/html/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ <h3>Display Options</h3>
<input type="checkbox" id="show-unstable">
Show unstable scenarios
</label>
<label>
<input type="checkbox" id="custom-range">
Adjust Y-axis for comparisons
</label>
</div>
</div>

Expand Down
Loading
Loading