-
Notifications
You must be signed in to change notification settings - Fork 792
[SYCL][matrix] Update the query interface with the latest joint matrix approved syntax #11004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…x approved syntax
This PR replaces #10847. It addresses most of the comments raised there. |
Currently |
sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In an offline discussion, we agreed on adding the new SPR enumerator |
…ix::combinations to matrix_combinations
@dm-vodopyanov, @gmlueck can you please approve the spec changes? |
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SYCL Pre Commit on Windows / Windows / SYCL E2E on Windows (pull_request) https://github.com/intel/llvm/actions/runs/6223657584/job/16898974221?pr=11004 seems like a common CI problem. @dkhaldi is this patch ready to be merged? |
@dkhaldi oh last-minute comment: spec has usage of |
Thanks, I fixed it here. |
@gmlueck, do the recent changes to the SPR addition look good now? If so, please approve the spec portion. |
sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc
Show resolved
Hide resolved
<< combinations.size() << std::endl; | ||
|
||
bool max_sizes; | ||
if (combinations[0].maxsize == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is maxsize
? There is no maxsize
in combination
struct. I will fix in the upcoming patch and enable (and re-write) the test for PVC, as this is a platform where we definitely test in this particular CI.
void matrix_runtime_query(queue q) { | ||
|
||
std::vector<combination> combinations = | ||
q.get_device().get_info<sycl::info::device::matrix_combinations>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl::ext::oneapi::experimental::info::device::matrix_combinations
@@ -39,7 +39,8 @@ void matrix_multiply(big_matrix<T1, NUM_ROWS_C, NUM_COLS_C> &C, | |||
size_t K = NUM_COLS_A; | |||
assert(NUM_ROWS_C == NUM_ROWS_A && NUM_COLS_A == NUM_ROWS_B * 4); | |||
|
|||
using myparams2 = tpu_params<tpu::amx, int8_t, int8_t, int>; | |||
using myparams2 = | |||
matrix_params<architecture::intel_cpu_spr, int8_t, int8_t, int>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be sycl::ext::oneapi::experimental::architecture.
otherwise, errmsg is reported
error: use of undeclared identifier 'architecture'
No description provided.