[Don't Merge] Add repeat frame flag and HEVC PAK statistics for multi-passes encoding #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenXiaomin0306
commented
Jun 25, 2023
ChenXiaomin0306
commented
- repeat frame flag to denote whether this is one new frame or repeated frame of previous frame for encoding context update.
- HEVC CU level stream out from PAK engine can be output to application.
Signed-off-by: ChenXiaomin0306 <[email protected]>
dvrogozh
reviewed
Jun 25, 2023
| /** \brief Buffer type used for sending repeat frame flag to the encoder */ | ||
| VAEncMiscParameterTypeRepeatFrame = 20, | ||
| /** \brief Buffer type used for HEVC Pak statistics */ | ||
| VAEncMiscParameterTypeHevcPakStat = 21 |
There was a problem hiding this comment.
Why only hevc? what about other codes - avc, av1, etc?
ChenXiaomin0306
changed the title
| VAEncMiscParameterTypeExtensionData = 19 | ||
| VAEncMiscParameterTypeExtensionData = 19, | ||
| /** \brief Buffer type used for sending repeat frame flag to the encoder */ | ||
| VAEncMiscParameterTypeRepeatFrame = 20, |
There was a problem hiding this comment.
could we reuse skip frame?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.