Skip to content

Pass module_id options through an internal API with smaller surface #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandolaerik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass module_id options through an internal API with smaller surface #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 11 additions & 21 deletions test/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,27 +612,17 @@ def run_linker(self):
self.pr("Creating module_id.c")

module_id_base = join(self.scratchdir, "module_id")
class options(object):
output = module_id_base + ".c"
modname = 'dml-test-' + self.shortname
classes = "test"
components = ""
user_version = None
user_build_id = ("__dmlc_tests__", 0)
cpumod = None
date = None
product = None
thread_safe = "no"
host_type = host_type()
py_version = None
py_iface_lists = []
iface_py_modules = []
init_c_wrappers = False
dml_devs = ([] if self.api_version in ["4.8"]
else ["T_" + self.shortname])
user_init_local = self.api_version in ["4.8"]

module_id.CModuleId(options, False).create_module_id()

args = module_id.parse_arguments([
f'--output={module_id_base}.c',
f'--module-name=dml-test-{self.shortname}',
'--classes=test',
'--host-type=linux64',
'--build-id=__dmlc_tests__:0',
'--user-init-local' if self.api_version == "4.8"
else f'--dml-dev=T_{self.shortname}'
])
module_id.CModuleId(args, False).create_module_id()

name = self.shortname
self.ld_stdout = join(self.scratchdir, name+'.ld_stdout')
Expand Down