-
Notifications
You must be signed in to change notification settings - Fork 547
feat: basic tests and doc changes for no-scan mode #5138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joydeep049
wants to merge
10
commits into
intel:main
Choose a base branch
from
joydeep049:no-scan-test-doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b34f3ae
feat: basic tests and doc changes for no-scan mode
joydeep049 7b6f460
doc: minor doc changes and licensing information
joydeep049 db27e44
Merge branch 'main' into no-scan-test-doc
joydeep049 e640405
fix: change entry point to cli.py
joydeep049 bc2bb7b
fix: skip failing tests and fix linter errors
joydeep049 de0a814
fix: isort linter fix
joydeep049 ac7fe17
chore: empty commit to re-run ci
joydeep049 1e5d646
Merge branch 'main' into no-scan-test-doc
joydeep049 35242da
Merge branch 'main' into no-scan-test-doc
joydeep049 5b96e2d
doc: minor changes
joydeep049 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Copyright (C) 2025 Intel Corporation | ||
# SPDX-License-Identifier: GPL-3.0-or-later | ||
|
||
import subprocess | ||
|
||
|
||
def test_no_scan_exists(): | ||
""" | ||
Test that --no-scan mode exists | ||
""" | ||
result = subprocess.run( | ||
["python3", "cve_bin_tool/cli.py", "--help"], | ||
capture_output=True, | ||
text=True, | ||
) | ||
|
||
output = result.stdout + result.stderr | ||
|
||
assert "no-scan" in output | ||
|
||
assert result.returncode == 0 | ||
|
||
|
||
# @pytest.mark.skip(reason="Failing due to unknown errors") | ||
def test_no_scan_output(): | ||
""" | ||
Test the tool with --no-scan flag | ||
""" | ||
result = subprocess.run( | ||
["python3", "cve_bin_tool/cli.py", "./experiments", "--no-scan"], | ||
capture_output=True, | ||
text=True, | ||
) | ||
|
||
assert "No Scan Mode: No CVE Scanning" in result.stdout | ||
|
||
|
||
def test_normal_scan(): | ||
""" | ||
Test Normal Scan without --no-scan flag | ||
""" | ||
result = subprocess.run( | ||
["python3", "cve_bin_tool/cli.py", "./experiments"], | ||
capture_output=True, | ||
text=True, | ||
) | ||
|
||
assert "No Scan Mode: No CVE Scanning" not in result.stdout |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this particular test is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Initially I tried
cve-bin-tool <directory> --no-scan
but that failedThen I changed the entry point to
cve_bin_tool/cli.py
but that seems to fail tooSurprising how
--no-scan
shows up inpython3 cve_bin_tool/cli.py --help
but not in the above