Skip to content

Add unit test for SBOM generation without scan #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

NeilMathew-git
Copy link

This adds a unit test that validates SBOMGenerate can generate a valid SBOM using mock scan data. The test bypasses scanning and external API calls, aligning with the goals of No-Scan Mode. It ensures output files are generated correctly and include relevant content.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved the tests to run so you can see what happens, but I'm not sure what you actually want to do with this PR since it's pretty useless by itself. Are you intending to close it after you see the results of the the CI run?

@NeilMathew-git
Copy link
Author

This PR was just a mock test for SBOM generation without scanning, in the spirit of what No-Scan Mode might eventually support. I understand without a working implementation of No-Scan Mode, the test doesn’t provide much value on its own. I was just experimenting and trying to get more familiar with the codebase.

I’m happy to close this PR if it’s not useful right now, or I can update the test to better reflect existing functionality if you think there’s a more helpful direction to take it. Let me know what you'd prefer.

@terriko
Copy link
Contributor

terriko commented Apr 24, 2025

Okay, i'm going to close this as un-mergeable, then. thanks for experimenting with it!

@terriko terriko closed this Apr 24, 2025
@NeilMathew-git
Copy link
Author

No problem. Let me know if there’s anything else I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants