-
Notifications
You must be signed in to change notification settings - Fork 528
fix:Add pyproject.toml #4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Add pyproject.toml #4873
Conversation
We're overdue to switch to pyproject.toml and actually having one would be nice because some of our linter config could move into there I think. I'm going to update this branch to make sure we don't get any weirdness with the build test but assuming that works we may be good to go. |
HI @terriko, can you let me know more what linter config we can move in this. |
Some of them have the options to store their config in pyproject.toml rather than in individual config files, I don't remember which ones off the top of my head but it's likely more of them than the last time I looked anyhow, but you can do the reading as well as I can. If you need links for the linters to look it up, they're in .pre-commit-config.yaml or listed https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters That said, don't change this PR, linter config should be a separate change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's taken so long! I'm still a little nervous that this is going to cause weirdness when I next release the package, but that's a me problem so I'm going to go ahead and fix the gitlint error and merge now.
Sure thing, also I was wondering if we have some research related issue. |
fixes #4872
I checked out this and it seems doing nothing was also an option but I added the pyproject.toml file as it was recommended, the setup.py file will work alongside pyproject.toml file
Thanks