fix: poolbuffer check refcount issue when using clang compiler #860
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Yanfeng-Mi, Thank you for your contribution. We have found several minor issues with your commit, like line length, commit type etc. |
Yanfeng-Mi
force-pushed
the
poolbuffer
branch
from
a1339ee to
ad68471
Compare
Yanfeng-Mi
changed the title
Yanfeng-Mi
changed the title
Author
|
The issue was traced to a subtle difference in std::unique_ptr's destruction process between Clang (libc++) and GCC (libstdc++). Clang's unique_ptr destructor first nullifies its internal pointer before calling the deleter, meaning that within the managed object's destructor, the owning pointer is already nullptr. In contrast, GCC's unique_ptr directly calls the deleter without first setting the internal pointer to nullptr. This difference caused a specific dependency or interaction within the managed object's destructor to behave incorrectly under GCC because it still saw a non-null owning pointer, leading to unexpected behavior during cleanup. PR is using flag-based system to replace the problematic pointer comparison ref intel#744 Signed-off-by: Mi, Yanfeng <[email protected]>
Yanfeng-Mi
force-pushed
the
poolbuffer
branch
from
ad68471 to
21b452e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iler
The issue root-caused to the subtle difference of unique_ptr's destructor between clang and gcc:
Clang (libc++): Calls unique_ptr's destructor, which first clears the internal pointer to nullptr and then calls the deleter on the old pointer value. This means that within the destructor of the managed object, the owning unique_ptr's internal pointer is already nullified.
GCC (libstdc++): The destructor directly calls the deleter on the current pointer without first setting it to nullptr
Fix: using flag-based system to replace the problematic pointer comparison ref #744