Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remaining Float16 specializations for simd calculation #78

Merged
merged 4 commits into from
Feb 20, 2025
Merged

feat: add remaining Float16 specializations for simd calculation #78

merged 4 commits into from
Feb 20, 2025

Conversation

ahuber21
Copy link
Contributor

@ahuber21 ahuber21 commented Feb 5, 2025

This PR adds the remaining Float16 specializations for CosineSimilarityImpl, resulting in SIMD ops being used instead of the generic reference implementation in some of the test cases.

@ibhati ibhati self-requested a review February 7, 2025 19:18
ibhati
ibhati approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@ibhati ibhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahuber21 ahuber21 force-pushed the dev/ahuber/cosine-simd-specializations branch from ef7ceca to 7bece3e Compare February 20, 2025 07:56
@ahuber21
Copy link
Contributor Author

ahuber21 commented Feb 20, 2025 •
edited
Loading

I brought the branch back to 7bece3e which is the approved commit c5c9bc9 plus merging origin/main to resolve conflicts plus 7bece3e which only removes the TODO comment as requested.

Merging after successful CI completion. Will open a separate PR for ef7ceca.

@ahuber21 ahuber21 merged commit 46a8a59 into main Feb 20, 2025
12 checks passed
@ahuber21 ahuber21 deleted the dev/ahuber/cosine-simd-specializations branch February 20, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaic mihaic mihaic left review comments

@ibhati ibhati ibhati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuber21 @mihaic @ibhati