Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and adapt AWS dependency to version 2.0 #222

Merged

Conversation

inigo-cobian
Copy link
Contributor

Changelog:

  • Updated the AWS dependencies to the new distribution
  • Changed the HortonMachine snapshot to a new version
  • Add s3BucketRegion parameter to STAC resources

@inigo-cobian inigo-cobian added the java Pull requests that update Java code label Jan 21, 2025
@inigo-cobian inigo-cobian requested a review from a team January 21, 2025 09:48
@inigo-cobian inigo-cobian self-assigned this Jan 21, 2025
@inigo-cobian inigo-cobian force-pushed the IM-524-Implement-the-S3-functionalities-at-k.LAB branch from 996f67f to 0e460e7 Compare January 22, 2025 08:09
@inigo-cobian inigo-cobian marked this pull request as ready for review January 22, 2025 08:19
@iperdomo
Copy link
Collaborator

Not sure why we want/need the S3 async client?
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/asynchronous.html

@inigo-cobian
Copy link
Contributor Author

inigo-cobian commented Jan 22, 2025

Not sure why we want/need the S3 async client?

At the moment I cannot think about a reason to prefer Async over Sync in k.LAB. But it probably has to do with downloading multiple resources in the HortonMachine. I'll take a look at it to be sure.

@inigo-cobian inigo-cobian merged commit 2cd3141 into develop Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants