Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valhalla travel connection gives error this.time threshold is null #213

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Valhalla travel connection gives error this.time threshold is null #213

merged 3 commits into from
Nov 29, 2024

Conversation

inigo-cobian
Copy link
Contributor

Changes:

  • Fixed trying to define an isochrone while timeThreshold was null
  • Made the units used for Valhalla (input/output) explicit
  • Set routing time input as seconds

@inigo-cobian inigo-cobian added bug Something isn't working java Pull requests that update Java code labels Nov 29, 2024
@inigo-cobian inigo-cobian requested a review from a team November 29, 2024 11:28
@inigo-cobian inigo-cobian self-assigned this Nov 29, 2024
iperdomo
iperdomo approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@iperdomo iperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@inigo-cobian inigo-cobian merged commit c6932b0 into develop Nov 29, 2024
2 checks passed
@inigo-cobian inigo-cobian deleted the IM-487-Valhalla-TravelConnection-gives-error-this.timeThreshold-is-null branch February 12, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iperdomo iperdomo iperdomo approved these changes

Assignees

@inigo-cobian inigo-cobian

Labels
bug Something isn't working java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inigo-cobian @iperdomo