Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Im 289 stac classification error #137

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Im 289 stac classification error #137

merged 4 commits into from
Feb 27, 2024

Conversation

inigo-cobian
Copy link
Contributor

With these changes, the adapter will try to get the type of the values in two ways:

@inigo-cobian inigo-cobian added the java Pull requests that update Java code label Feb 27, 2024
@inigo-cobian inigo-cobian self-assigned this Feb 27, 2024
iperdomo
iperdomo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@iperdomo iperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 LGTM, Still don't understand the change from String to Object 😕

@inigo-cobian inigo-cobian merged commit 536d899 into develop Feb 27, 2024
2 checks passed
@inigo-cobian inigo-cobian deleted the IM-289-STAC-Classification-Error branch March 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iperdomo iperdomo iperdomo approved these changes

@euskalhenriko euskalhenriko Awaiting requested review from euskalhenriko

@kristinaBc3 kristinaBc3 Awaiting requested review from kristinaBc3

Assignees

@inigo-cobian inigo-cobian

Labels
java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inigo-cobian @iperdomo