Im 73 users dont use email as unique and primary key 2 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Create an API call for the requesting.
…. Create an API call for the requesting.
…. Create an API call for the requesting.
…EmailResponse in the API response if the token is verifyed.
…and password are correct create function to update the email address in mongo and ldap, also set the user in the authentication context.
…. refactor:Delete some warnings and clean code.
iperdomo
reviewed
Feb 14, 2024
| import org.springframework.data.annotation.TypeAlias; | ||
|
|
||
| @TypeAlias("VerifyEmail") | ||
| public class TokenVerifyEmailClickback extends TokenClickback { | ||
|
|
||
| private static final long serialVersionUID = 2577854654763037014L; | ||
| private String notVerifiedEmail; |
There was a problem hiding this comment.
Question about naming (we know that naming is hard 😅): notVerifiedEmail vs newEmail ?
iperdomo
reviewed
Feb 14, 2024
| } else if(type.equals(TokenType.verifyEmail)) { | ||
| return new CreateVerifyEmailToken(repository, username, linkConfig).execute(); | ||
| } else { | ||
| return null; |
There was a problem hiding this comment.
Do we want to return null or throw an Exception? 🤔
There was a problem hiding this comment.
Is for keeping the same structure.
| throw new ActivationTokenFailedException("User Verification token failed"); | ||
| } | ||
| if (token == null) { | ||
| throw new ActivationTokenFailedException("User Verification token failed"); |
There was a problem hiding this comment.
Why don't we use a different error message for the missing token and the exception?
There was a problem hiding this comment.
Is unreacheable code, I'll delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.