Im 256 export networks from the k.explorer #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library-versions Unify version of testing libraries
The intention is to *pin* the version of maven to use
* We use a new jdk17 agent without maven installed to avoid the `MAVEN_CONFIG` environment variable * carlossg/docker-maven#301 (comment)
Revert a change that brake the communication of app UI after an observation
Im 252 maven wrapper
- We don't expect to move credentials to GitHub, just basic "sanity check" (build)
* Some tests require MongoDB and other external services :/
* skipTests by default
…ons-for-PeopleEA Im 247 UI modifications for people ea
inigo-cobian
commented
Jan 31, 2024
| @@ -247,7 +247,7 @@ public void setGenerator(Activity generator) { | |||
| */ | |||
| @Override | |||
| public boolean is(Class<?> cls) { | |||
| return peers.get(cls) != null; | |||
There was a problem hiding this comment.
These changes, and the ones at as() are not just random whitespaces. At an intermediate commit, I added some logic here that was later moved to DirectObservation.
inigo-cobian
merged commit 3fad102
into
IM-238-USA-Recreation-IDB-request-information-state-by-state-from-the-API
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Opened as a draft because we are waiting for the user acceptance test.