Skip to content

Run e2e tests on PRs#67

Merged
evatapai merged 17 commits intomainfrom
e2egithub
Mar 16, 2026
Merged

Run e2e tests on PRs#67
evatapai merged 17 commits intomainfrom
e2egithub

Conversation

@evatapai
Copy link
Contributor

@evatapai evatapai commented Mar 13, 2026 •
edited
Loading

refs: SAS-4761

In this PR:

  • I added e2e tests as part of github actions
  • I put it into a separate job to make e2e testing more standalone and easier to debug.
  • The logout test turned out to be flaky in the CI environment, so I updated it to be more stable.
  • I realized some actions don't pull the latest packages so updated those as well.
  • A possibly unintended behavior has been discovered where after logout the code simply returns next with a 404, instead of redirecting with a 3xx. This should be investigated I think.

@evatapai
Run e2e tests on PRs
a6658f3 
Change-Id: I0307302021c0bca5de64651f2c26a0687f47b0ea
@github-actions
Copy link

github-actions bot commented Mar 13, 2026 •
edited
Loading

✅ Test Results

Test Summary

Category Suites Tests Passed Failed Status
Unit 20 205 205 0 ✅
Integration 3 36 36 0 ✅
Total 23 241 241 0 ✅

Coverage

Metric Percentage
Lines 70.83%
Statements 70.95%
Functions 68.95%
Branches 79.93%

Updated: 2026-03-13 15:24:30 UTC

evatapai added 16 commits March 13, 2026 07:54
@evatapai
Use upload-artifact@v4
1cbe46e 
Change-Id: Ib77ac678f36e36ad6682a290c863dfa9140cfcc9
@evatapai
Wait for web until health check passes
99a79b4 
Change-Id: I079a52a9bb521b77a21c626b4f456b4d2f14efc8
@evatapai
Lets not rely on health check with curl dependency
327fbe5 
Change-Id: I6b4395592c8b4287e78d44226fe8980e03adb56f
@evatapai
start all containers for e2e tests
1f3743c 
Change-Id: Ib3d4324dc4a9609c794b0b656023bd6bc8bc6cfe
@evatapai
health check and web build matching ci web build
1289f8e 
Change-Id: I5730162e5ee275e7788978d8e9c6f0f5cf56e478
@evatapai
updating actions/checkout to v4
eb3c956 
Change-Id: Ie67c4bc84068ee785b31b70b8084d5929b538dd9
@evatapai
setup-buildx-action to v3
74d80f6 
Change-Id: I13eda9f70cdc49fbaec8305021fc20c34efb5fee
@evatapai
setup node v4
ec9d645 
Change-Id: I9c18c70beecb5a7fbbdb21f281b302388cdec5ed
@evatapai
fix flaky logout test
b6d765b 
Change-Id: Ie5d607249a3c2a99e8ecb3f681fe274a0993706c
@evatapai
lint fix
c45f4aa 
Change-Id: I65ff546b53591158404c3b4a48fa5b9c848f6dcd
@evatapai
actions/cache to v4
e5bddaa 
Change-Id: If18af1b0994470ce8a402ce48b10d5a809798abc
@evatapai
Do we need health check in docker?
65651a3 
Change-Id: I10701fe5abaa3b7fcab7d512df2ad73d82ba692f
@evatapai
Directories should be created during docker-compose bind mount
83aacae 
Change-Id: Ida1ab0f425e9e73f9b5aea56ad3289c1cc14471d
@evatapai
Test: let's keep data even when everything passes
49d23d3 
Change-Id: I27a5416e39049d53d6395703974b777d482e9a75
@evatapai
small cleanup
dfe6545 
Change-Id: I628fea429d3cd3e8b731be15f367990e9587fcd7
@evatapai
mini syntax cleanup
f5dc32d 
Change-Id: If0e7bc816df3acefb9ecf7198d93788b0e74fa7c
ppesti
ppesti approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@ppesti ppesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Evi.

@evatapai evatapai merged commit 5a318cd into main Mar 16, 2026
4 checks passed
@evatapai evatapai deleted the e2egithub branch March 16, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppesti ppesti ppesti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evatapai @ppesti