fix(ui-scripts): fixed a shallow merge bug in generatesemantics.ts#2558
Closed
adamlobler wants to merge 1 commit into
Closed
fix(ui-scripts): fixed a shallow merge bug in generatesemantics.ts#2558adamlobler wants to merge 1 commit into
adamlobler wants to merge 1 commit into
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
matyasf
reviewed
May 14, 2026
matyasf
force-pushed
the
fix-semantic-token-generation
branch
from
665abbe to
3f13143
Compare
…at was dropping color tokens when building themes
matyasf
force-pushed
the
fix-semantic-token-generation
branch
from
3f13143 to
0846820
Compare
Collaborator
Author
|
@HerrTopi will take over this issue. I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergeSemanticSetsused a shallow spread. Every semantic JSON file wraps its contents under a single top-level "semantic" key, so when color and layout files were merged, the layout's semantic object silently overwrote the color one. The deep merge now recursively combines both instead.