feat(ui-scripts): add publish-private command for private-registry releases#2555
Merged
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
matyasf
requested changes
May 14, 2026
| // No --provenance: only npmjs supports it. | ||
| // No --registry flag: the temp .npmrc handles registry + auth. | ||
| ], | ||
| childEnv |
Collaborator
There was a problem hiding this comment.
I would include a small delay between calling this. We ran into very inconvenient errors when calling this 80+ times without delay, the command started failing after a while (npmjs's DDOS protection?).
I suggest to add a small delay here too (we were using 500ms)
Contributor
Author
There was a problem hiding this comment.
good call, adding it
| PRIVATE_TAG, | ||
| '--no-git-checks' | ||
| // No --provenance: only npmjs supports it. | ||
| // No --registry flag: the temp .npmrc handles registry + auth. |
Collaborator
There was a problem hiding this comment.
I dont see this flag in the docs https://pnpm.io/cli/publish
Collaborator
There was a problem hiding this comment.
I'm talking about --registry
balzss
force-pushed
the
publish-to-custom-registry
branch
2 times, most recently
from
7369857 to
95c499c
Compare
balzss
force-pushed
the
publish-to-custom-registry
branch
from
95c499c to
43aa634
Compare
matyasf
approved these changes
May 15, 2026
…leases Adds a new `ui-scripts publish-private` command that publishes all non-private packages to a private npm-compatible registry. Intended for distributing fixes to a small set of consumers before a public release. The command reads INSTUI_PRIVATE_REGISTRY and INSTUI_PRIVATE_REGISTRY_TOKEN from the environment, refuses any npmjs.org host as a hard guard, prompts the operator to confirm the registry hostname (skippable with --yes), and writes an isolated .npmrc to a temp dir via NPM_CONFIG_USERCONFIG so the user's global config is left untouched. Each package is published under the `security` dist-tag with `--no-git-checks` and no `--provenance`. The existing `publish` command, npm.js helpers, and release workflows are unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
balzss
force-pushed
the
publish-to-custom-registry
branch
from
43aa634 to
eabb624
Compare
HerrTopi
approved these changes
May 15, 2026
Contributor
HerrTopi
left a comment
HerrTopi
left a comment
There was a problem hiding this comment.
Seems good to me, giving thumbs up with cautious optimism, hope everything will work properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pnpm run publish-privatefor publishing all non-private packages to an npm-compatible private registry. Used to ship pre-release builds of security fixes to selected consumers ahead of the public release.Reads
INSTUI_PRIVATE_REGISTRYandINSTUI_PRIVATE_REGISTRY_TOKENfrom the environment. The existing public release path (pnpm run release, OIDC, GitHub workflows) is untouched.Why a separate command
pnpm run releaseis invoked on master push and OIDC-publishes to npmjs. Overloading it would mean a mis-set env var could leak embargoed code to the public registry. A distinct command isolates the private path and its guard rails.Safety
*.npmjs.org.--yes)..npmrcfor the publish subprocesses only — user/project.npmrcuntouched, cleaned up infinally.securitysopnpm installwon't resolve a private build by accident.Usage
What this PR does NOT do
publish.js.Test Plan
pnpm run publish-private --helpshows the--yesflag.Draft until the version-bump PR lands and the end-to-end flow can be walked through.