-
Notifications
You must be signed in to change notification settings - Fork 52
Fixes for chat eval layout and auto-scroll #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes for chat eval layout and auto-scroll #672
Conversation
cb016b5
to
9e98465
Compare
@jeff-phillips-18 @vishnoianil sorry I have a few questions here.
|
Yes
Error state for stopped or not running, spinner for loading/unloading
We currently show the state of the model server, if you think we only need error status or pending status we can do that
Yes
we could do that
The model server could be temporarily down. The user would no longer see their history if we showed an empty state instead. |
215fce9
to
220e13f
Compare
220e13f
to
64c539d
Compare
@Misjohns Please take another look. Updated the screen shots above. |
I need help understanding how the Free GPUs counter and the No GPUs Free status text relate. Questions below.
I think it is better to display the No GPUs Free to the right of the model selector and treat as a plain alert with an icon. I also think this should just be a warning. Regarding the single input box. I believe that should be the default since the goal is to compare the responses between 2 models. I recommend we change the toggle to "Display two input boxes". Not sure if input boxes is the correct term, looks like most UIs refer to it as a message input. @kaedward thoughts on wording for that toggle? |
0/1 means zero free GPUs of the 1 GPU on the server.
We can assume that if we select a model and it is ready then that model is using 1 of the GPUs. Prior to that we don't know which model is using the GPU.
👍 |
64c539d
to
5ba19c1
Compare
@Misjohns Updated the |
For the switch, I recommend using sentence case (recommended across the UI) - so “Single input box”. Although I think it could be simpler to say “Share commands” and have it switched “on” by default. WDYT? Same for the “No GPUs free” alert - although I’d suggest changing it to “No GPUs available”. “Free” is a term we try to avoid when possible because of its $$ connotations. I’d also change the “Free GPUs” label to “Available GPUs”. I also have some unprompted feedback on the page title/description... 😁 Compare models |
@kaedward I personally would not know that "Share commands" meant "Show 2 input fields". Also, the default view should have a single input field so the toggle would be not to share commands, when toggled on 2 input fields display so user could ask chat with each model individually. |
a2ae0c0
to
368389e
Compare
Signed-off-by: Jeffrey Phillips <[email protected]>
368389e
to
468edab
Compare
@jeff-phillips-18 Based on our UXD call the toggle should read "Use separate prompts" and the placehold text in input field should change to "Enter prompt…" |
Fixes Job logs displayed above the chat bot input box in case of "Single Input Box" is selected.
Fixes Chat eval chat bot doesn't scroll down automatically
Fixes Chat Eval UI not showing the status
Description
Additionally fixes some other layout/css issues in the Chat eval.
Uses the message area to inform the user if the model is not running or if it is loading.
Screen shots